-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libcxxwrap 0.8.5 for Julia 1.5 #2158
libcxxwrap 0.8.5 for Julia 1.5 #2158
Conversation
Actually, I wonder: right now we do |
Hmm, lots of build failures:
Wonder if that indicates a potential issue with libjulia_jll 1.5... sigh |
Damn, this is turning out to be quite the rabbit hole :/ These all seem to be from libunwind. |
From my perspective, it's been a rabbit hole for several weeks (months?) now already, so I'll call this par for the course :-). Anyway, yeah, this probably needs to be addressed in libjulia_jll 1.5: I notice that it lacks a dependency on I'll try to figure it out next week, but now I need to catch some sleep. Perhaps @vchuravy has an idea in the meantime... |
Since version 1.5 julia uses a shared libunwind on linux + freebsd instead of a static library which explains why this happens for these architectures and not for 1.3 and 1.4. (I am not sure about macos ...) The build script seems to fall back to it's own downloader for libunwind since neither But that shared library is never installed into |
544ace9
to
051950e
Compare
So if I add In the meantime, I also modified this PR here to set the |
051950e
to
2fa769b
Compare
@@ -59,4 +59,4 @@ dependencies = [ | |||
|
|||
# Build the tarballs, and possibly a `build.jl` as well. | |||
build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies; | |||
preferred_gcc_version = v"7", julia_compat = "~$(julia_version.major).$(julia_version.minor)") | |||
preferred_gcc_version = v"7", julia_compat = "^$(julia_version.major).$(julia_version.minor)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? Doesn't the caret mean compatible with [1.5, 2.0)
? Is this what you want?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, well, if this actually works with julia v1.6 that's good 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it works in Julia 1.6 (at least on a mac, but it should work everywhere)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(famous last words 😝 )
It's 18 hours too late, but this is indeed perfect, thanks @fingolfin ! |
This is marked as a draft, as it shouldn't be merged immediately; instead, first...
CC @barche